Discussion:
LiS-2.18 - lis_spin_is_locked_fcn
Gary Schumacher
2006-04-01 17:19:49 UTC
Permalink
We are running LIS 2.18 on a PPC platform and it seems that spin locks are not working.
Looking at head/linux/lislocks.c, it looks like they have been disabled for the PPC. Is this
correct, am I reading this correctly?

Thanks
Gary Schumacher

int _RP lis_spin_is_locked_fcn(lis_spin_lock_t *lock, FL)
{
DCL_l ;
(void) file; (void) line ;
(void) l ; /* compiler happiness in 2.2 */
#if defined(_PPC_LIS_)
return(0) ; /* PPC does not define this, odd */
#else
return(spin_is_locked(l)) ;
#endif
}


SPECIAL NOTICE

All information transmitted hereby is intended only for the use of the
addressee(s) named above and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution
of confidential and privileged information is prohibited. If the reader
of this message is not the intended recipient(s) or the employee or agent
responsible for delivering the message to the intended recipient, you are
hereby notified that you must not read this transmission and that disclosure,
copying, printing, distribution or use of any of the information contained
in or attached to this transmission is STRICTLY PROHIBITED.

Anyone who receives confidential and privileged information in error should
notify us immediately by telephone and mail the original message to us at
the above address and destroy all copies. To the extent any portion of this
communication contains public information, no such restrictions apply to that
information. (gate01)
Brian F. G. Bidulock
2006-04-01 17:53:27 UTC
Permalink
Gary,

Although spin_is_locked() was not defined on some earlier ports to PPC
it has been in all 2.4+ kernels for a long time now. It think that the
#ifdef could be removed.

This is just one of the problems with wrappering kernel functions with
lis_ functions of the same name. (The other is, of course, licensing,
which does _not_ magically change from GPL to LGPL.)

So why are you using these lis_ lock functions at all?

--brian
Post by Gary Schumacher
We are running LIS 2.18 on a PPC platform and it seems that spin locks are not working.
Looking at head/linux/lislocks.c, it looks like they have been disabled for the PPC. Is this
correct, am I reading this correctly?
Thanks
Gary Schumacher
int _RP lis_spin_is_locked_fcn(lis_spin_lock_t *lock, FL)
{
DCL_l ;
(void) file; (void) line ;
(void) l ; /* compiler happiness in 2.2 */
#if defined(_PPC_LIS_)
return(0) ; /* PPC does not define this, odd */
#else
return(spin_is_locked(l)) ;
#endif
}
SPECIAL NOTICE
All information transmitted hereby is intended only for the use of the
addressee(s) named above and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution
of confidential and privileged information is prohibited. If the reader
of this message is not the intended recipient(s) or the employee or agent
responsible for delivering the message to the intended recipient, you are
hereby notified that you must not read this transmission and that disclosure,
copying, printing, distribution or use of any of the information contained
in or attached to this transmission is STRICTLY PROHIBITED.
Anyone who receives confidential and privileged information in error should
notify us immediately by telephone and mail the original message to us at
the above address and destroy all copies. To the extent any portion of this
communication contains public information, no such restrictions apply to that
information. (gate01)
_______________________________________________
Linux-streams mailing list
http://gsyc.escet.urjc.es/mailman/listinfo/linux-streams
--
Brian F. G. Bidulock ¦ The reasonable man adapts himself to the ¦
***@openss7.org ¦ world; the unreasonable one persists in ¦
http://www.openss7.org/ ¦ trying to adapt the world to himself. ¦
¦ Therefore all progress depends on the ¦
¦ unreasonable man. -- George Bernard Shaw ¦
Loading...